M. Warner Losh
imp at bsdimp.com
Thu Mar 4 17:58:52 UTC 2010
In message: <4B8F3F4B.7020002 at FreeBSD.org>
Maxim Sobolev <sobomax at FreeBSD.org> writes:
: Warner Losh wrote:
: > Author: imp
: > Date: Wed Mar 3 21:53:25 2010
: > New Revision: 204672
: > URL: http://svn.freebsd.org/changeset/base/204672
: > Log:
: > Cast these to intmax_t before printing to fix build bustage. Better
: > solutions welcome.
: Thanks for a quick fix and sorry for the breakage. IMHO you fix's
: fine, there is no real reason to use 64-bit quantity anyway, it's just
: because expand_number(3) interface is not very well designed and
: forces anyone using it stick with that data type. So downsizing from
: 64-bit to 32-bit on platforms where intmax_t is 32-bit only (if any)
: should not be an issue in real life.
Yea, but as others have pointed out, this seems to point out that
there's interface problems, and things have silently changed from
needing to be int to needing to be int64_t, which breaks on i386...
More information about the svn-src-all