svn commit: r209490 - head/sys/kern

John Baldwin jhb at freebsd.org
Thu Jun 24 12:07:54 UTC 2010


On Wednesday 23 June 2010 10:56:46 pm Juli Mallett wrote:
> On Wed, Jun 23, 2010 at 19:26, M. Warner Losh <imp at bsdimp.com> wrote:
> 
> > : > #    define HZ 1000
> > : > #  else
> > : > #    define HZ 100
> >
> > Shouldn't this be defined in some file in ARCH/include instead?

Yes, machine/param.h should work just fine.  We could leave a default of 1000 
via the current #ifndef and just move the non-default settings into MD 
headers.

> Didn't it used to be?  I think the problem with doing that is that
> then someone inevitably writes code that uses HZ instead of the
> (tunable) hz.  Of course, you can hide it behind an obscure #ifdef and
> even give it an intimidating name.

No, it's been in subr_param.c since at least 4.4BSD.

-- 
John Baldwin


More information about the svn-src-all mailing list