svn commit: r208923 - stable/8/sys/dev/sge

Pyun YongHyeon yongari at FreeBSD.org
Tue Jun 8 19:26:23 UTC 2010


Author: yongari
Date: Tue Jun  8 19:26:22 2010
New Revision: 208923
URL: http://svn.freebsd.org/changeset/base/208923

Log:
  MFC r208806:
    Don't blindly set IFF_DRV_OACTIVE when sge_encap() fails. If there
    is no queued frame, IFF_DRV_OACTIVE would never be cleared.
  
    Submitted by:	Nikolay Denev < ndenev <> gmail at com >
    Approved by:	re (bz)

Modified:
  stable/8/sys/dev/sge/if_sge.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)
  stable/8/sys/geom/sched/   (props changed)

Modified: stable/8/sys/dev/sge/if_sge.c
==============================================================================
--- stable/8/sys/dev/sge/if_sge.c	Tue Jun  8 18:36:03 2010	(r208922)
+++ stable/8/sys/dev/sge/if_sge.c	Tue Jun  8 19:26:22 2010	(r208923)
@@ -1588,8 +1588,9 @@ sge_start_locked(struct ifnet *ifp)
 		if (m_head == NULL)
 			break;
 		if (sge_encap(sc, &m_head)) {
-			if (m_head != NULL)
-				IFQ_DRV_PREPEND(&ifp->if_snd, m_head);
+			if (m_head == NULL)
+				break;
+			IFQ_DRV_PREPEND(&ifp->if_snd, m_head);
 			ifp->if_drv_flags |= IFF_DRV_OACTIVE;
 			break;
 		}


More information about the svn-src-all mailing list