svn commit: r210471 - in head: sbin/camcontrol sys/cam sys/cam/ata sys/cam/scsi sys/dev/ahci sys/dev/ata sys/dev/mvs sys/dev/siis sys/geom

Alexander Motin mav at FreeBSD.org
Sun Jul 25 20:19:35 UTC 2010


Hi.

Scott Long wrote:
> I'm tired of CCB structure sizes changing willie nillie, whether in a CURRENT branch or not.  This should have been a new CCB, not a add-on to an existing CCB.  All your patch does it break binary compatibility.

This only changes size of "struct ccb_pathinq", other structures are not
affected, so driver ABI breakage is minimal. We did the same when adding
maxio field. Do you think I should remake this?

PS: Actually it was your words: "I think that there are reasonable ways
to address this though, by having CAM SIMs provide a bit more
information in their PATH_INQ response."

> On Jul 25, 2010, at 9:43 AM, Alexander Motin wrote:
>> Author: mav
>> Date: Sun Jul 25 15:43:52 2010
>> New Revision: 210471
>> URL: http://svn.freebsd.org/changeset/base/210471
>>
>> Log:
>> Export PCI IDs of ATA/SATA controllers through CAM and ata(4) layers to
>> GEOM. This information needed for proper soft-RAID's on-disk metadata
>> reading and writing.
>>
>> Modified:
>> head/sbin/camcontrol/camcontrol.c
>> head/sys/cam/ata/ata_da.c
>> head/sys/cam/cam_ccb.h
>> head/sys/cam/scsi/scsi_cd.c
>> head/sys/cam/scsi/scsi_da.c
>> head/sys/dev/ahci/ahci.c
>> head/sys/dev/ata/ata-all.c
>> head/sys/dev/ata/ata-disk.c
>> head/sys/dev/mvs/mvs.c
>> head/sys/dev/siis/siis.c
>> head/sys/geom/geom_disk.c
>> head/sys/geom/geom_disk.h

-- 
Alexander Motin


More information about the svn-src-all mailing list