svn commit: r210321 - head/lib/libelf

[Brian Somers]

On Wed, 21 Jul 2010 19:51:49 +1000 (EST) Bruce Evans <brde at optusnet.com.au> wrote:
> On Wed, 21 Jul 2010, Alexey Dokuchaev wrote:
> 
> > On Wed, Jul 21, 2010 at 08:43:48AM +0000, Kai Wang wrote:
> >> Log:
> >>   Remove a superfluous comment.
> >>
> >>   Obtained from:	     elftoolchain
> >>   MFC after:	     1 month
> >
> > (Just picking random of the similar commits): guys, please, try to
> > uniformly align commit meta tags:
> 
> It is perfectly aligned with tabs (and no 2-char commit mail indentation,
> and no N-char mailer quoting).
> 
> > Obtained from:	somewhere
> > MFC after:	sometime
> > Foo bar:	baz qux ...
> >
> > Broken alignment considerably pessimizes commit log grasping, as it
> > requires more post-processing work after reading it off.
> 
> Do you mean for human grasping and automated post-processing?  The automation
> should have no problems with the whitespace but might with the mailer quoting.
> 
> "tags" should mean the part before the ":".  Aligning those by making them
> all of the same length would help.

Alternatively, indenting commit mail sections with a tab rather than two spaces would
preserve the visual alignment.

-- 
Brian Somers                                          <brian at Awfulhak.org>
Don't _EVER_ lose your sense of humour !               <brian at FreeBSD.org>