svn commit: r203149 - head/sys/mips/rmi

[Bruce Evans]

On Fri, 29 Jan 2010, Randall Stewart wrote:

> Log:
>  Move ID up into comment block.. per bsdimp

Any chance of fixing the ~10 other style bugs visible in this patch?  There
are 6 new ones in this commit alone:

> Modified: head/sys/mips/rmi/pic.h
> ==============================================================================
> --- head/sys/mips/rmi/pic.h	Fri Jan 29 03:35:01 2010	(r203148)
> +++ head/sys/mips/rmi/pic.h	Fri Jan 29 04:03:36 2010	(r203149)
> @@ -25,14 +25,15 @@
>  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
>  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>  * SUCH DAMAGE.
> + * __FBSDID("$FreeBSD$");

1. Missing blank line before $FreeBSD$.
2. Using the __FBSDID() macro in a comment is nonsense.
3. Insertion sort error.  $FreeBSD$ goes last in the copyright comment.

>  *
>  * RMI_BSD */

4. Block comments are not formatted like this in KNF.

> #ifndef _RMI_PIC_H_
> #define _RMI_PIC_H_

5. Space instead of tab after #define.
6. Missing blank line before whatever follws the idempotency ifndef/def.

> #include <sys/cdefs.h>
> -/*
> -__FBSDID("$FreeBSD$");
> -*/
> +

7. Extra blank line.

> +

8. Extra blank line.

> +

9. Extra blank line.

>
> extern int rmi_spin_mutex_safe;

10. KNF would indent this using a tab or two.

>
>

The 6 new style bugs are 1-3 and 7-9.

Bruce