svn commit: r202279 - head/lib/libc/gen

[Alexander Kabaev]

On Thu, 14 Jan 2010 10:00:01 +0000 (UTC)
Ed Schouten <ed at FreeBSD.org> wrote:

> Author: ed
> Date: Thu Jan 14 10:00:01 2010
> New Revision: 202279
> URL: http://svn.freebsd.org/changeset/base/202279
> 
> Log:
>   Revert the change to Symbol.map, made in r202274.
>   
>   Even though we use __sym_compat(), we should list the symbol in
>   Symbol.map.
>   
>   ttyslot() is now listed as follows, which seems to do the right
> thing: 
>   | Symbol table '.dynsym' contains 2755 entries:
>   |    Num:    Value          Size Type    Bind   Vis      Ndx Name
>   |    613: 00000000000477b0   121 FUNC    GLOBAL DEFAULT   10
> ttyslot at FBSD_1.0 
>   Reported by:	kib
> 
> Modified:
>   head/lib/libc/gen/Symbol.map
> 
> Modified: head/lib/libc/gen/Symbol.map
> ==============================================================================
> --- head/lib/libc/gen/Symbol.map	Thu Jan 14 09:38:23
> 2010	(r202278) +++ head/lib/libc/gen/Symbol.map	Thu Jan
> 14 10:00:01 2010	(r202279) @@ -272,6 +272,7 @@ FBSD_1.0 {
>  	openlog;
>  	closelog;
>  	setlogmask;
> +	ttyslot;
>  	ttyname_r;
>  	ttyname;
>  	timezone;

Unnecessary, despite of what kib says. It was exported with proper
version by __sym_compat already. This line in Symbol map is a NOP
because there's no unadorned global 'ttyslot' symbol in the library
for it to apply.

Please back it out. 

-- 
Alexander Kabaev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20100114/93b360c0/signature.pgp