svn commit: r204222 - head/sys/dev/gem
Marius Strobl
marius at FreeBSD.org
Mon Feb 22 21:01:08 UTC 2010
Author: marius
Date: Mon Feb 22 21:01:08 2010
New Revision: 204222
URL: http://svn.freebsd.org/changeset/base/204222
Log:
According to the Linux sungem driver, in case of Apple (K2) GMACs
GEM_MIF_CONFIG_MDI0 cannot be trusted when the firmware has powered
down the chip so the internal transceiver has to be hardcoded. This
is also in line with the AppleGMACEthernet driver, which just doesn't
distinguish between internal/external transceiver and MDIO/MDI1
respectively in the first place. Tested by: Andreas Tobler
MFC after: 1 week
Modified:
head/sys/dev/gem/if_gem.c
Modified: head/sys/dev/gem/if_gem.c
==============================================================================
--- head/sys/dev/gem/if_gem.c Mon Feb 22 20:42:30 2010 (r204221)
+++ head/sys/dev/gem/if_gem.c Mon Feb 22 21:01:08 2010 (r204222)
@@ -297,8 +297,11 @@ gem_attach(struct gem_softc *sc)
/*
* Fall back on an internal PHY if no external PHY was found.
+ * Note that with Apple (K2) GMACs GEM_MIF_CONFIG_MDI0 can't be
+ * trusted when the firmware has powered down the chip.
*/
- if (error != 0 && (v & GEM_MIF_CONFIG_MDI0) != 0) {
+ if (error != 0 &&
+ ((v & GEM_MIF_CONFIG_MDI0) != 0 || GEM_IS_APPLE(sc))) {
v &= ~GEM_MIF_CONFIG_PHY_SEL;
GEM_BANK1_WRITE_4(sc, GEM_MIF_CONFIG, v);
switch (sc->sc_variant) {
More information about the svn-src-all
mailing list