svn commit: r203875 - head/sys/kern

Konstantin Belousov kib at FreeBSD.org
Sun Feb 14 13:59:01 UTC 2010


Author: kib
Date: Sun Feb 14 13:59:01 2010
New Revision: 203875
URL: http://svn.freebsd.org/changeset/base/203875

Log:
  Do not leak process lock when current thread is not allowed to see target.
  
  Bumped into by:	ed
  MFC after:	3 days

Modified:
  head/sys/kern/kern_event.c

Modified: head/sys/kern/kern_event.c
==============================================================================
--- head/sys/kern/kern_event.c	Sun Feb 14 12:31:28 2010	(r203874)
+++ head/sys/kern/kern_event.c	Sun Feb 14 13:59:01 2010	(r203875)
@@ -349,8 +349,10 @@ filt_procattach(struct knote *kn)
 
 	if (p == NULL)
 		return (ESRCH);
-	if ((error = p_cansee(curthread, p)))
+	if ((error = p_cansee(curthread, p))) {
+		PROC_UNLOCK(p);
 		return (error);
+	}
 
 	kn->kn_ptr.p_proc = p;
 	kn->kn_flags |= EV_CLEAR;		/* automatically set */


More information about the svn-src-all mailing list