svn commit: r203696 - in head: lib/libc/sys sys/kern sys/sys

Marcel Moolenaar xcllnt at mac.com
Tue Feb 9 19:18:10 UTC 2010


On Feb 9, 2010, at 10:40 AM, Kostik Belousov wrote:

*snip*

Action items:

>>> - vmspace should be referenced by vmspace_acquire_ref()
>>> - vm_map should be read-locked before iterating the map entries.

*snip*

>> We can always put the timestamp in the structure.

*snip*

>> (2) the tracing process can check the timestamp returned by each
>>    request and compare that with the return value of the
>>    PT_VM_TIMESTAMP and restart the iteration.

*snip*

> I agree that #2 looks preferably, except that I consider it more
> convenient when libc syscall wrapper return value is 0/-1 instead
> of -1/some data. This means that timestamp might be added to
> the existing struct ptrace_vm_entry.

Of course.  When I said returned, I didn't mean returned as the
return value from ptrace. I used return to convey origin and
direction of the information flow (see also the first sentence
of my response :-)

I'll implement it and send a patch for review to avoid unnecessary
repository churn...

Thanks!

-- 
Marcel Moolenaar
xcllnt at mac.com





More information about the svn-src-all mailing list