svn commit: r216518 - in head/sys/dev: if_ndis le malo sound/pci

[Paul B Mahol]

On 12/18/10, Tijl Coosemans <tijl at freebsd.org> wrote:
> On Saturday 18 December 2010 19:41:13 Paul B Mahol wrote:
>> On 12/18/10, Tijl Coosemans <tijl at freebsd.org> wrote:
>>> Author: tijl
>>> Date: Sat Dec 18 14:21:28 2010
>>> New Revision: 216518
>>> URL: http://svn.freebsd.org/changeset/base/216518
>>>
>>> Log:
>>>   Use convenience functions where possible instead of accessing the PCI
>>>   configuration registers directly.
>>>
>>>   Remove pci_enable_io calls where they are redundant. The PCI bus driver
>>>   will set the right bits when the corresponding bus resource is
>>> activated.
>>>
>>>   Remove redundant pci_* function calls from suspend/resume methods. The
>>>   bus driver already saves and restores the PCI configuration.
>>>
>>>   Reviewed by:	jhb
>>>   Approved by:	kib (mentor)
>>
>> Please revert change to if_ndis regarding introduction of
>> pci_get_subvendor().
>>
>> You compare 16bit value with 32bit value - this will always fail.
>
> Apologies. Instead of reverting, would the attached patch work for you?
> It moves the function calls out of the while loop and makes it more clear
> what subsys means.

Looks fine.