svn commit: r216291 - head/cddl/contrib/opensolaris/lib/libzfs/common

Martin Matuska mm at FreeBSD.org
Wed Dec 8 09:14:17 UTC 2010


Here are some arguments:

a) it was removed in OpenSolaris rev. 12865:08987220809a
b) a root pool does not not have to be a boot pool

So if we need a warning here, it should print only some general
suggestion because
user may attach any vdev (e.g. a file or a memory disk) to make a mirror
from a root pool.
And as this was removed upstream the warning should be put into perforce
as well.

Dňa 08.12.2010 10:04, Pawel Jakub Dawidek  wrote / napísal(a):
> On Wed, Dec 08, 2010 at 08:57:37AM +0000, Martin Matuska wrote:
>> Author: mm
>> Date: Wed Dec  8 08:57:37 2010
>> New Revision: 216291
>> URL: http://svn.freebsd.org/changeset/base/216291
>>
>> Log:
>>   Do not print OpenSolaris hint to use (non-existing) installgrub(1) command
>>   if creating a mirror by attaching a new vdev to a root pool.
> This warning is helpful, just incorrect. It should be changed to show
> steps that are needed on FreeBSD and not just commented out.
> I left it on purpose as a reminder.
>


More information about the svn-src-all mailing list