svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Pawel Jakub Dawidek]

On Mon, Dec 06, 2010 at 07:44:53PM +0100, Pawel Jakub Dawidek wrote:
> On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote:
> > Author: ivoras
> > Date: Mon Dec  6 12:18:02 2010
> > New Revision: 216230
> > URL: http://svn.freebsd.org/changeset/base/216230
> > 
> > Log:
> >   Use GEOM stripesize field when calculating ashift. This will enable correct
> >   alignment on drives with large sector sizes (e.g. 4 KiB) but the
> >   implementation might need to be revisited if devices with large stripesizes
> >   appear (e.g. if RAID controllers or flash drives start using the field),
> >   probably by introducing a physsectorsize field in GEOM providers.
> 
> Please back this out as soon as possible!
> 
> >   Discussed with: mav, mostly silence on freebsd-geom@ and freebsd-fs@
> 
> Guess why it wasn't picked up by anyone?

In other words... Stop hack around. This is so irritating.

If disk lies about its sector size, add quirks at the layer where disk
is discovered. Don't hack ZFS, UFS, any other file system and GEOM
classes, because its easiest for you. It would be best if you could just
leave it to mav@ who knows this area and knows what he is doing. Those
drive-by hacks of yours are really doing more evil than good.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20101206/752cea99/attachment.pgp