svn commit: r211327 - head/sys/netinet

[Andre Oppermann]

On 15.08.2010 11:41, Bjoern A. Zeeb wrote:
> On Sun, 15 Aug 2010, Andre Oppermann wrote:
>
>> Author: andre
>> Date: Sun Aug 15 09:30:13 2010
>> New Revision: 211327
>> URL: http://svn.freebsd.org/changeset/base/211327
>>
>> Log:
>> Add more logging points for failures in syncache_socket() to
>> report when a new socket couldn't be created because one of
>> in_pcbinshash(), in6_pcbconnect() or in_pcbconnect() failed.
>>
>> Logging is conditional on net.inet.tcp.log_debug being enabled.
>>
>> MFC after: 1 week
>>
>> Modified:
>> head/sys/netinet/tcp_syncache.c
>>
>> Modified: head/sys/netinet/tcp_syncache.c
>> ==============================================================================
>>
>> --- head/sys/netinet/tcp_syncache.c Sun Aug 15 08:49:07 2010 (r211326)
>> +++ head/sys/netinet/tcp_syncache.c Sun Aug 15 09:30:13 2010 (r211327)
>> @@ -627,6 +627,7 @@ syncache_socket(struct syncache *sc, str
>> struct inpcb *inp = NULL;
>> struct socket *so;
>> struct tcpcb *tp;
>> + int error = 0;
>
>
> Is there any need to initialize here?

No.  Actually not.  Was just my style of using safe initial values.
But here the return value is the socket pointer of NULL.  The error
is not passed back directly.

Fixed in r211332.

Thanks for noticing and reporting.

-- 
Andre