svn commit: r211221 - head/usr.sbin/acpi/acpidump

Dag-Erling Smørgrav des at des.no
Thu Aug 12 15:03:38 UTC 2010


Takanori Watanabe <takawata at FreeBSD.org> writes:
> -	printf("\tClass %d Base Address 0x%jx Length %llu\n\n",
> +	printf("\tClass %d Base Address 0x%jx Length %" PRIu64 "\n\n",
>  	    tcpa->platform_class, paddr, len);

This is just as wrong as the previous attempt.

1) platform_class is not an int.
2) paddr is not a uintmax_t.
3) so far, we've avoided using the PRI macros.

Slightly better:

	printf("\tClass %u Base Address 0x%jx Length %ju\n\n",
  	    (unsigned int)tcpa->platform_class, (uintmax_t)paddr, (uintmax_t)len);

but it would probably be easier to define paddr and len as unsigned long
long instead of the misspelled u_int64_t, and use %llx and %llu.

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the svn-src-all mailing list