svn commit: r206140 - head/sys/vm

[Alan Cox]

K. Macy wrote:
> How has the problem been addressed? I'm seeing periodic panics with
> non-zero resident count with the page lock patch applied. It is
> possible that I've inadvertently re-introduced an issue you've fixed.
>
>   

r196318 and r189783 come to mind.

>
> On Sat, Apr 3, 2010 at 9:20 AM, Alan Cox <alc at freebsd.org> wrote:
>   
>> Author: alc
>> Date: Sat Apr  3 16:20:22 2010
>> New Revision: 206140
>> URL: http://svn.freebsd.org/changeset/base/206140
>>
>> Log:
>>  Re-enable the call to pmap_release() by vmspace_dofree().  The accounting
>>  problem that is described in the comment has been addressed.
>>
>>  Submitted by: kib
>>  Tested by:    pho (a few months ago)
>>  MFC after:    6 weeks
>>
>> Modified:
>>  head/sys/vm/vm_map.c
>>
>> Modified: head/sys/vm/vm_map.c
>> ==============================================================================
>> --- head/sys/vm/vm_map.c        Sat Apr  3 15:52:32 2010        (r206139)
>> +++ head/sys/vm/vm_map.c        Sat Apr  3 16:20:22 2010        (r206140)
>> @@ -313,6 +313,7 @@ vm_init2(void)
>>  static inline void
>>  vmspace_dofree(struct vmspace *vm)
>>  {
>> +
>>        CTR1(KTR_VM, "vmspace_free: %p", vm);
>>
>>        /*
>> @@ -329,12 +330,8 @@ vmspace_dofree(struct vmspace *vm)
>>        (void)vm_map_remove(&vm->vm_map, vm->vm_map.min_offset,
>>            vm->vm_map.max_offset);
>>
>> -       /*
>> -        * XXX Comment out the pmap_release call for now. The
>> -        * vmspace_zone is marked as UMA_ZONE_NOFREE, and bugs cause
>> -        * pmap.resident_count to be != 0 on exit sometimes.
>> -        */
>> -/*     pmap_release(vmspace_pmap(vm)); */
>> +       pmap_release(vmspace_pmap(vm));
>> +       vm->vm_map.pmap = NULL;
>>        uma_zfree(vmspace_zone, vm);
>>  }
>>
>>
>>