svn commit: r196300 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris cddl/contrib/opensolaris/uts/common/fs/zfs contrib/dev/acpica contrib/pf dev/ata dev/cxgb dev/mfi dev/xen/netfron...

[Pawel Jakub Dawidek]

On Fri, Sep 25, 2009 at 04:13:49PM -0400, Adam McDougall wrote:
> Pawel Jakub Dawidek wrote:
> >Author: pjd
> >Date: Mon Aug 17 09:23:27 2009
> >New Revision: 196300
> >URL: http://svn.freebsd.org/changeset/base/196300
> >
> >Log:
> >  MFC r196299:
> >  
> >  - We need to recycle vnode instead of freeing znode.
> >  
> >  Submitted by:	avg
> >  
> >  - Add missing vnode interlock unlock.
> >  - Remove redundant znode locking.
> >  
> >  Approved by:	re (kib)
> >
> 
> Two quick questions:
> 
> - Do you think this fix would improve or fix the panic below?
>   (transcribed by hand since it did not dump and I only have a
>    screenshot)
> - Are the many misc ZFS fixes that went into 9.0 and 8.0 going to
>   be MFC'ed to 7-stable sometime, including the one above? I have
>   lucked out pretty well so far since May.

At this point I'm not going to MFC them into stable/7, although marck@
seems to be interested in doing it.

> Sleeping thread (tid 100161), pid 919) owns a non-sleepable lock
> sched_switch() at sched_switch+0x1fe
> mi_switch() at mi_switch+0x18e
> sleepq_wait() at sleepq_wait+0x3b
> _sx_xlock_hard() at _sx_xlock_hard+0x1ee
> _sx_xlock() at _sx_xlock+0x4e
> rrw_enter() at rrw_enter+0xa4
> zfs_freebsd_getattr() at zfs_freebsd_getattr+0x9d
> filt_vfsread() at filt_vfsread+_0x5e
> knote() at knote+0xc2

It looks like kqueue is calling into ZFS with mutex held, which is
bad... No, this bug is not fixed.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20090925/0afb0930/attachment.pgp