svn commit: r196779 - in head/sys: kern sys
Kostik Belousov
kostikbel at gmail.com
Thu Sep 3 19:15:55 UTC 2009
On Thu, Sep 03, 2009 at 01:40:41PM +0000, Attilio Rao wrote:
> Author: attilio
> Date: Thu Sep 3 13:40:41 2009
> New Revision: 196779
> URL: http://svn.freebsd.org/changeset/base/196779
>
> Log:
> Add intermediate states for attaching and detaching that will be
> reused by the enhached newbus locking once it is checked in.
> This change can be easilly MFCed to STABLE_8 at the appropriate moment.
>
> Reviewed by: jhb, scottl
> Tested by: Giovanni Trematerra <giovanni dot trematerra at gmail dot com>
>
....
> Modified: head/sys/sys/bus.h
> ==============================================================================
> --- head/sys/sys/bus.h Thu Sep 3 12:41:00 2009 (r196778)
> +++ head/sys/sys/bus.h Thu Sep 3 13:40:41 2009 (r196779)
> @@ -52,8 +52,11 @@ struct u_businfo {
> typedef enum device_state {
> DS_NOTPRESENT, /**< @brief not probed or probe failed */
> DS_ALIVE, /**< @brief probe succeeded */
> + DS_ATTACHING, /**< @brief attaching is in progress */
> DS_ATTACHED, /**< @brief attach method called */
> - DS_BUSY /**< @brief device is open */
> + DS_BUSY, /**< @brief device is open */
> + DS_DETACHING /**< @brief detaching is in progress */
> +
> } device_state_t;
Since device_state_t is exposed to consumers and started to be modified,
would it make sense to add explicit values for enumeration members,
with enough gap in between ? It seems to give more freedom for newbus
locking work with regard to backward-compatible ABI changes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-all/attachments/20090903/edac1b1a/attachment.pgp
More information about the svn-src-all
mailing list