svn commit: r197654 - head/sys/dev/if_ndis
sam at freebsd.org
Fri Oct 2 03:02:02 UTC 2009
Bruce Evans wrote:
> On Thu, 1 Oct 2009, [utf-8] Dag-Erling SmÃ¸rgrav wrote:
>> Coleman Kane <cokane at FreeBSD.org> writes:
>>> - if (sc->ndis_80211 && vap)
>>> + if ((sc->ndis_80211 != NULL) && (vap != NULL))
>> sc->ndis_80211 is an int. NULL is a pointer.
> Also, the number of style bugs was doubled on (almost?) every changed line
> by adding 2 sets of unnecessary parentheses.
FWIW I simply asked he compare ptr's against NULL. The excessive
paren's hurt my eyes too :-)
More information about the svn-src-all