svn commit: r198940 - head/sys/gnu/fs/ext2fs
Jaakko Heinonen
jh at FreeBSD.org
Thu Nov 5 04:51:39 UTC 2009
Author: jh
Date: Thu Nov 5 04:51:38 2009
New Revision: 198940
URL: http://svn.freebsd.org/changeset/base/198940
Log:
File flags handling fixes for ext2fs:
- Disallow setting of flags not supported by ext2fs.
- Map EXT2_APPEND_FL to SF_APPEND.
- Map EXT2_IMMUTABLE_FL to SF_IMMUTABLE.
- Map EXT2_NODUMP_FL to UF_NODUMP.
Note that ext2fs doesn't support user settable append and immutable flags.
EXT2_NODUMP_FL is an user settable flag also on Linux.
PR: kern/122047
Reported by: Ighighi
Submitted by: Aditya Sarawgi (original version)
Reviewed by: bde
Approved by: trasz (mentor)
Modified:
head/sys/gnu/fs/ext2fs/ext2_inode_cnv.c
head/sys/gnu/fs/ext2fs/ext2_vnops.c
Modified: head/sys/gnu/fs/ext2fs/ext2_inode_cnv.c
==============================================================================
--- head/sys/gnu/fs/ext2fs/ext2_inode_cnv.c Thu Nov 5 03:54:03 2009 (r198939)
+++ head/sys/gnu/fs/ext2fs/ext2_inode_cnv.c Thu Nov 5 04:51:38 2009 (r198940)
@@ -83,8 +83,9 @@ ext2_ei2i(ei, ip)
ip->i_mtime = ei->i_mtime;
ip->i_ctime = ei->i_ctime;
ip->i_flags = 0;
- ip->i_flags |= (ei->i_flags & EXT2_APPEND_FL) ? APPEND : 0;
- ip->i_flags |= (ei->i_flags & EXT2_IMMUTABLE_FL) ? IMMUTABLE : 0;
+ ip->i_flags |= (ei->i_flags & EXT2_APPEND_FL) ? SF_APPEND : 0;
+ ip->i_flags |= (ei->i_flags & EXT2_IMMUTABLE_FL) ? SF_IMMUTABLE : 0;
+ ip->i_flags |= (ei->i_flags & EXT2_NODUMP_FL) ? UF_NODUMP : 0;
ip->i_blocks = ei->i_blocks;
ip->i_gen = ei->i_generation;
ip->i_uid = ei->i_uid;
@@ -121,8 +122,9 @@ ext2_i2ei(ip, ei)
ei->i_ctime = ip->i_ctime;
ei->i_flags = ip->i_flags;
ei->i_flags = 0;
- ei->i_flags |= (ip->i_flags & APPEND) ? EXT2_APPEND_FL: 0;
- ei->i_flags |= (ip->i_flags & IMMUTABLE) ? EXT2_IMMUTABLE_FL: 0;
+ ei->i_flags |= (ip->i_flags & SF_APPEND) ? EXT2_APPEND_FL: 0;
+ ei->i_flags |= (ip->i_flags & SF_IMMUTABLE) ? EXT2_IMMUTABLE_FL: 0;
+ ei->i_flags |= (ip->i_flags & UF_NODUMP) ? EXT2_NODUMP_FL : 0;
ei->i_blocks = ip->i_blocks;
ei->i_generation = ip->i_gen;
ei->i_uid = ip->i_uid;
Modified: head/sys/gnu/fs/ext2fs/ext2_vnops.c
==============================================================================
--- head/sys/gnu/fs/ext2fs/ext2_vnops.c Thu Nov 5 03:54:03 2009 (r198939)
+++ head/sys/gnu/fs/ext2fs/ext2_vnops.c Thu Nov 5 04:51:38 2009 (r198940)
@@ -391,6 +391,10 @@ ext2_setattr(ap)
return (EINVAL);
}
if (vap->va_flags != VNOVAL) {
+ /* Disallow flags not supported by ext2fs. */
+ if (vap->va_flags & ~(SF_APPEND | SF_IMMUTABLE | UF_NODUMP))
+ return (EOPNOTSUPP);
+
if (vp->v_mount->mnt_flag & MNT_RDONLY)
return (EROFS);
/*
More information about the svn-src-all
mailing list