svn commit: r198706 - head/sys/sys

Robert N. M. Watson rwatson at FreeBSD.org
Sun Nov 1 16:15:22 UTC 2009


On 1 Nov 2009, at 15:33, Ed Schouten wrote:

> Because d_kind is a pointer, there will be a hole in the structure  
> of at
> least 2 bytes (maybe even 6), which means we can safely extend  
> d_mode to
> 32 bits as well. I could have decided to leave it at uint16_t, but  
> that
> would only obfuscate it even more when we would try to reclaim some
> space there.
>
> d_list is just two pointers, so I merged it with d_kind into an  
> array of
> three pointers

No, you're right, and I was mistaken, it seems fine on i386 and amd64.  
And, at least here, d_devs is at the same offset on both  
architectures. The only really "weird" architecture is arm, which I  
believe aligns char and short to 32-bit, but that should be OK here I  
think as well.

Robert


More information about the svn-src-all mailing list