svn commit: r190462 - head/sys/dev/wpi

[Sam Leffler]

Juli Mallett wrote:
> Author: jmallett
> Date: Fri Mar 27 05:44:53 2009
> New Revision: 190462
> URL: http://svn.freebsd.org/changeset/base/190462
>
> Log:
>   Put the "%d retries" debug message in the transmit path behind WPI_DEBUG_TX
>   rather than behind a seemingly accidental constant likely left over from one of
>   the related drivers which uses log levels rather than per-facility debugging
>   flags.  This should get rid of contextless messages on the console for people
>   who have not set (or cleared the default) debugging flags.
>
> Modified:
>   head/sys/dev/wpi/if_wpi.c
>
> Modified: head/sys/dev/wpi/if_wpi.c
> ==============================================================================
> --- head/sys/dev/wpi/if_wpi.c	Fri Mar 27 05:35:12 2009	(r190461)
> +++ head/sys/dev/wpi/if_wpi.c	Fri Mar 27 05:44:53 2009	(r190462)
> @@ -1587,7 +1587,7 @@ wpi_tx_intr(struct wpi_softc *sc, struct
>  	 */
>  	wn->amn.amn_txcnt++;
>  	if (stat->ntries > 0) {
> -		DPRINTFN(3, ("%d retries\n", stat->ntries));
> +		DPRINTFN(WPI_DEBUG_TX, ("%d retries\n", stat->ntries));
>  		wn->amn.amn_retrycnt++;
>  	}
>  
>   

wlan_amrr has macros to replace all the direct frobbing of data 
structures and also it's own debug messages that are enabled with 
wlandebug rate.  Might be worth cleaning up the driver (and might also 
improve performance if my reading of the code is right).

    Sam