svn commit: r194844 - in head/sys: conf dev/ata

[Alexander Motin]

Rafal Jaworowski wrote:
> Author: raj
> Date: Wed Jun 24 15:38:17 2009
> New Revision: 194844
> URL: http://svn.freebsd.org/changeset/base/194844
> 
> Log:
>   Move non-PCI prototypes from ata-pci.h -> ata-all.h.
>   
>   This removes unnecessary PCI #includes dependency for systems with ATA
>   controllers living at non-PCI buses.
>   
>   Submitted by:	Piotr Ziecik
>   Obtained from:	Semihalf
> 
> Modified: head/sys/conf/files
> ==============================================================================
> --- head/sys/conf/files	Wed Jun 24 15:33:33 2009	(r194843)
> +++ head/sys/conf/files	Wed Jun 24 15:38:17 2009	(r194844)
> @@ -491,12 +491,12 @@ dev/ata/ata_if.m		optional ata | atacore
>  dev/ata/ata-all.c		optional ata | atacore
>  dev/ata/ata-lowlevel.c		optional ata | atacore
>  dev/ata/ata-queue.c		optional ata | atacore
> +dev/ata/ata-dma.c		optional ata | atadma
> +dev/ata/ata-sata.c		optional ata | atasata

What is atadma and atasata here, kernel options? What for are they 
needed? You will not be able to build most of drivers without them, 
while enabling them for others will not give you any benefit, just 
bigger code size. I think dependency must be reviewed there.

-- 
Alexander Motin