svn commit: r191255 - in head/sys: amd64/conf conf i386/conf net

[Kip Macy]

its opt-out now

On Tue, Jun 9, 2009 at 8:01 AM, Bjoern A. Zeeb<bz at freebsd.org> wrote:
> On Sun, 19 Apr 2009, Kip Macy wrote:
>
>> Author: kmacy
>> Date: Sun Apr 19 00:16:04 2009
>> New Revision: 191255
>> URL: http://svn.freebsd.org/changeset/base/191255
>>
>> Log:
>>  - Import infrastructure for caching flows as a means of accelerating L3
>> and L2 lookups
>>   as well as providing stateful load balancing when used with RADIX_MPATH.
>>  - Currently compiled in to i386 and amd64 but disabled by default, it can
>> be enabled at
>>   runtime with 'sysctl net.inet.flowtable.enable=1'.
>>
>>  - Embedded users can remove it entirely from the kernel by adding
>> 'nooption FLOWTABLE' to
>>   their kernel config files.
>>
>>  - A minimal hookup will be added to ip_output in a subsequent commit. I
>> would like to see
>>   more review before bringing in changes that require more churn.
>>
>>  Supported by: Bitgravity Inc.
>>
>> Added:
>>  head/sys/net/flowtable.c   (contents, props changed)
>>  head/sys/net/flowtable.h   (contents, props changed)
>> Modified:
>>  head/sys/amd64/conf/DEFAULTS
>
>  ...
>>
>>  head/sys/i386/conf/DEFAULTS
>
>  ...
>>
>> Modified: head/sys/amd64/conf/DEFAULTS
>>
>> ==============================================================================
>> --- head/sys/amd64/conf/DEFAULTS        Sat Apr 18 22:16:46 2009
>>  (r191254)
>> +++ head/sys/amd64/conf/DEFAULTS        Sun Apr 19 00:16:04 2009
>>  (r191255)
>> @@ -20,3 +20,5 @@ options       GEOM_PART_BSD
>> options         GEOM_PART_EBR
>> options         GEOM_PART_EBR_COMPAT
>> options         GEOM_PART_MBR
>> +
>> +options                FLOWTABLE
>>
>> Modified: head/sys/i386/conf/DEFAULTS
>>
>> ==============================================================================
>> --- head/sys/i386/conf/DEFAULTS Sat Apr 18 22:16:46 2009        (r191254)
>> +++ head/sys/i386/conf/DEFAULTS Sun Apr 19 00:16:04 2009        (r191255)
>> @@ -28,3 +28,5 @@ options       GEOM_PART_MBR
>> # enable support for native hardware
>> options         NATIVE
>> device          atpic
>> +
>> +options                FLOWTABLE
>
> ...
>
>
>
> I think FLOWTABLE does nto belong into DEFAULTS.  Really DEFAULTS was
> meant for "You cannot boot without this" and if people start to weaken
> it, DEFAULTS will soon be the new GENERIC.  That said I am not sure it
> belongs to GENERIC either.
>
> --
> Bjoern A. Zeeb                      The greatest risk is not taking one.
>



-- 
When bad men combine, the good must associate; else they will fall one
by one, an unpitied sacrifice in a contemptible struggle.

    Edmund Burke