svn commit: r191292 - head/libexec/rtld-elf

Robert Watson rwatson at FreeBSD.org
Mon Apr 20 10:37:55 UTC 2009


On Mon, 20 Apr 2009, Bruce Evans wrote:

>>  Explicitly include machine/param.h for CACHE_LINE_SIZE.
>>
>>  MFC after:	2 weeks
>> 
>> Modified:
>>  head/libexec/rtld-elf/rtld_lock.c
>
> It is a style bug (unwarranted chumminess with the implementation) to 
> include (or otherwise refer to) machine/param.h directly in *.c.  This is 
> only the 5th instance of this style bug in all of /usr/src.  The previous 
> ones are:

I think rtld would count as part of "the implementation" from most 
perspectives, but I agree, and have made the change :-).

Robert N M Watson
Computer Laboratory
University of Cambridge


More information about the svn-src-all mailing list