svn commit: r191028 - head/sys/kern
Kip Macy
kmacy at FreeBSD.org
Mon Apr 13 23:09:45 UTC 2009
Author: kmacy
Date: Mon Apr 13 23:09:44 2009
New Revision: 191028
URL: http://svn.freebsd.org/changeset/base/191028
Log:
- use a shared lock for reads
- remove stale comment
Reviewed by: jeffr
Modified:
head/sys/kern/vfs_vnops.c
Modified: head/sys/kern/vfs_vnops.c
==============================================================================
--- head/sys/kern/vfs_vnops.c Mon Apr 13 23:08:37 2009 (r191027)
+++ head/sys/kern/vfs_vnops.c Mon Apr 13 23:09:44 2009 (r191028)
@@ -379,14 +379,8 @@ vn_rdwr(rw, vp, base, len, offset, segfl
!= 0)
return (error);
vn_lock(vp, LK_EXCLUSIVE | LK_RETRY);
- } else {
- /*
- * XXX This should be LK_SHARED but I don't trust VFS
- * enough to leave it like that until it has been
- * reviewed further.
- */
- vn_lock(vp, LK_EXCLUSIVE | LK_RETRY);
- }
+ } else
+ vn_lock(vp, LK_SHARED | LK_RETRY);
}
ASSERT_VOP_LOCKED(vp, "IO_NODELOCKED with no vp lock held");
More information about the svn-src-all
mailing list