svn commit: r185344 - in head/sys: netinet netinet6

[Robert Watson]

On Wed, 26 Nov 2008, Max Laier wrote:

> On Wednesday 26 November 2008 21:52:27 Bjoern A. Zeeb wrote:
>> Author: bz
>> Date: Wed Nov 26 20:52:26 2008
>> New Revision: 185344
>> URL: http://svn.freebsd.org/changeset/base/185344
>>
>> Log:
>>   Remove in6_pcbdetach() as it is exactly the same function
>>   as in_pcbdetach() and we don't need the code twice.
>>
>>   Reviewed by:	rwatson
>>   MFC after:	6 weeks (*)
>>   (*) possibly need to leave a stub wrapper in 7 to keep the symbol.
>
> Won't this affect our ability to build INET6, but non INET kernels?  Not 
> that we currently could, but if we ever wanted to?

INET6 already depends on other things in_pcb.c directly, such as 
in_pcballoc().  The distinction made between struct inpcb and struct in6pcb is 
artificial, and mostly quite confusing, so we've been gradually eliminating 
it.  It's largely incompatible with the implementation of IPv4 addresses 
mapped into the IPv6 space, which relies on IPv6 sockets being able to be in 
IPv4 connection lists, etc.  We have long-term plans to eliminate most of the 
macro aliasing of fields between the one structure.

Robert N M Watson
Computer Laboratory
University of Cambridge