svn commit: r184789 - in head: lib/libc/amd64/sys lib/libc/arm/sys lib/libc/i386/sys lib/libc/ia64/sys lib/libc/mips/sys lib/libc/powerpc/sys lib/libc/sparc64/sys sys/amd64/linux32 sys/compat/freeb...

Robert Watson rwatson at FreeBSD.org
Mon Nov 10 17:32:14 PST 2008


On Sun, 9 Nov 2008, Ed Schouten wrote:

> Modified: head/sys/sys/priv.h
> ==============================================================================
> --- head/sys/sys/priv.h	Sun Nov  9 09:24:01 2008	(r184788)
> +++ head/sys/sys/priv.h	Sun Nov  9 10:45:13 2008	(r184789)
> @@ -84,7 +84,6 @@
> #define	PRIV_CLOCK_SETTIME	17	/* Can call clock_settime. */
> #define	PRIV_SETTIMEOFDAY	18	/* Can call settimeofday. */
> #define	PRIV_SETHOSTID		19	/* Can call sethostid. */
> -#define	PRIV_SETDOMAINNAME	20	/* Can call setdomainname. */

Because kernel modules and applications may have been compiled with a specific 
understanding of what privilege '20' is, I think it would be a good idea to 
leave a placeholder name here to discourage reallocation of the same privilege 
number to a new privilege.  For example:

#define	_PRIV_SETDOMAINNAME	20	/* Removed. */

This would help prevent future accidents, and we might want to add a note 
along those lines to the comments in priv.h.

Robert N M Watson
Computer Laboratory
University of Cambridge


More information about the svn-src-all mailing list