svn commit: r184706 - head/usr.sbin/cron/crontab

Matteo Riondato matteo at FreeBSD.org
Wed Nov 5 20:53:02 PST 2008


Author: matteo
Date: Thu Nov  6 04:53:02 2008
New Revision: 184706
URL: http://svn.freebsd.org/changeset/base/184706

Log:
  Be paranoid and zero out passwd
  
  PR:	122070
  Submitted by:	Steven Kreuzer <skreuzer at exit2shell.com>
  Reminded by:    gnn@
  MFC after:	3 days

Modified:
  head/usr.sbin/cron/crontab/crontab.c

Modified: head/usr.sbin/cron/crontab/crontab.c
==============================================================================
--- head/usr.sbin/cron/crontab/crontab.c	Thu Nov  6 04:51:09 2008	(r184705)
+++ head/usr.sbin/cron/crontab/crontab.c	Thu Nov  6 04:53:02 2008	(r184706)
@@ -138,6 +138,7 @@ parse_args(argc, argv)
 
 	if (!(pw = getpwuid(getuid())))
 		errx(ERROR_EXIT, "your UID isn't in the passwd file, bailing out");
+	bzero(pw->pw_passwd, strlen(pw->pw_passwd));
 	(void) strncpy(User, pw->pw_name, (sizeof User)-1);
 	User[(sizeof User)-1] = '\0';
 	strcpy(RealUser, User);
@@ -154,6 +155,7 @@ parse_args(argc, argv)
 				errx(ERROR_EXIT, "must be privileged to use -u");
 			if (!(pw = getpwnam(optarg)))
 				errx(ERROR_EXIT, "user `%s' unknown", optarg);
+			bzero(pw->pw_passwd, strlen(pw->pw_passwd));
 			(void) strncpy(User, pw->pw_name, (sizeof User)-1);
 			User[(sizeof User)-1] = '\0';
 			break;


More information about the svn-src-all mailing list