svn commit: r184652 - in head/sys: dev/hwpmc fs/procfs kern

John Baldwin jhb at freebsd.org
Tue Nov 4 16:48:47 PST 2008


On Tuesday 04 November 2008 05:22:47 pm Ivan Voras wrote:
> 2008/11/4 John Baldwin <jhb at freebsd.org>:
> > Author: jhb
> > Date: Tue Nov  4 19:04:01 2008
> > New Revision: 184652
> > URL: http://svn.freebsd.org/changeset/base/184652
> >
> > Log:
> >  Remove unnecessary locking around vn_fullpath().  The vnode lock for the
> 
> Does this affect realpath(3)? (whose non-scalability is often reported
> for PHP web servers).

realpath(3) calls getcwd(3) (which devolves to __getcwd(2) I think) once per 
invocation (and that already did not lock the vnode).  It then calls lstat() 
for each component in the path.  The lstat() calls should be using shared 
locks (at least with the recent changes to use shared lookups for UFS in 
HEAD).  I imagine the bottleneck is more with lstat() than getcwd(3).  
Neither is helped by the specific changes above.

-- 
John Baldwin


More information about the svn-src-all mailing list