svn commit: r186076 - head/sys/amd64/amd64

[Garrett Cooper]

On Sun, Dec 14, 2008 at 1:27 AM, Niclas Zeising
<niclas.zeising at gmail.com> wrote:
> Garrett Cooper wrote:
>>
>> On Sun, Dec 14, 2008 at 1:06 AM, Joseph Koshy <jkoshy at freebsd.org> wrote:
>>>
>>> Author: jkoshy
>>> Date: Sun Dec 14 09:06:28 2008
>>> New Revision: 186076
>>> URL: http://svn.freebsd.org/changeset/base/186076
>>>
>>> Log:
>>>  Bug fix: %ebx needs to be preserved in the user callchain capture
>>>  path.
>>>
>>> Modified:
>>>  head/sys/amd64/amd64/exception.S
>>>
>>> Modified: head/sys/amd64/amd64/exception.S
>>>
>>> ==============================================================================
>>> --- head/sys/amd64/amd64/exception.S    Sun Dec 14 06:40:04 2008
>>>  (r186075)
>>> +++ head/sys/amd64/amd64/exception.S    Sun Dec 14 09:06:28 2008
>>>  (r186076)
>>> @@ -459,9 +459,9 @@ nmi_calltrap:
>>>        */
>>>       movq    %rsp,%rsi       /* source stack pointer */
>>>       movq    $TF_SIZE,%rcx
>>> -       movq    PCPU(RSP0),%rbx
>>> -       subq    %rcx,%rbx
>>> -       movq    %rbx,%rdi       /* destination stack pointer */
>>> +       movq    PCPU(RSP0),%rdx
>>> +       subq    %rcx,%rdx
>>> +       movq    %rdx,%rdi       /* destination stack pointer */
>>>
>>>       shrq    $3,%rcx         /* trap frame size in long words */
>>>       cld
>>> @@ -470,7 +470,7 @@ nmi_calltrap:
>>>
>>>       movl    %ss,%eax
>>>       pushq   %rax            /* tf_ss */
>>> -       pushq   %rbx            /* tf_rsp (on kernel stack) */
>>> +       pushq   %rdx            /* tf_rsp (on kernel stack) */
>
>                   ^^^^^^
>>>
>>>       pushfq                  /* tf_rflags */
>>>       movl    %cs,%eax
>>>       pushq   %rax            /* tf_cs */
>>
>> Stupid question -- where's the change? All I see are potentially
>> whitespace modifications..
>> -Garrett
>
> %rbx is changed to a %rdx in some places, I hilighted one.
> Regards!
> //Niclas

Yeah, I know. I'm just blind as a bat ><.
-Garrett