socsvn commit: r253790 - in soc2013/jmuniz: . PackageKit-Setter

[jmuniz at FreeBSD.org]

Author: jmuniz
Date: Mon Jul  1 10:08:37 2013
New Revision: 253790
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=253790

Log:
  pk-setter now restarts the daemon. Updated TODO.

Modified:
  soc2013/jmuniz/PackageKit-Setter/pk-setter
  soc2013/jmuniz/TODO

Modified: soc2013/jmuniz/PackageKit-Setter/pk-setter
==============================================================================
--- soc2013/jmuniz/PackageKit-Setter/pk-setter	Mon Jul  1 09:53:06 2013	(r253789)
+++ soc2013/jmuniz/PackageKit-Setter/pk-setter	Mon Jul  1 10:08:37 2013	(r253790)
@@ -87,10 +87,16 @@
     generateBackendList
     # Determine if the backend provided is valid, each option is surrounded by spaces
     case "${PK_BACKENDS}" in
-      # If the proved backend is valid
+      # If the provided backend is valid
       *" $2 "*) 
+        # Ask PackageKit to quietly close as soon as it can
+        gdbus call --system --dest org.freedestop.PackageKit --object-path /org/freedestop/PackageKit --method org.freedestop.PackageKit.SuggestDaemonQuit >/dev/null
         # Find the first instance of "DefaultBackend" in the configuration file and edit it
         sed "s/DefaultBackend=.*/DefaultBackend=$2/" ${PK_PREFIX}etc/PackageKit/PackageKit.conf > ${PK_PREFIX}etc/PackageKit/PackageKit.conf
+        # Sync the disks to make sure the configuration file is updated
+        sync
+        # Silently start PackageKit
+        pkcon >/dev/null
         # Inform the user of success
         echo "PackageKit is now using the $2 backend"
         ;;

Modified: soc2013/jmuniz/TODO
==============================================================================
--- soc2013/jmuniz/TODO	Mon Jul  1 09:53:06 2013	(r253789)
+++ soc2013/jmuniz/TODO	Mon Jul  1 10:08:37 2013	(r253790)
@@ -2,11 +2,10 @@
 -----------------------------
 
 pk-setter:
-- when setting the backend, close packagekitd before, sync(8) and start packagekitd after
 - generate backend list without hardcoding it
-- make sure file permissions are correct
-- move a copy of the license agreement to this directory
 - determine if the BSD license can be used this intimately with GPLv2
 - verify that packagekitd starts with new configuration, or roll back to last known good configuration
 - create a new port to share this script 
+- determine if 'pkcon refresh' is needed when changing backends, it doesn't seem to want to work in 0.6.11
+- make script more robust in the face of missing dependencies