svn commit: r566529 - head/x11/foot
Jan Beich
jbeich at FreeBSD.org
Thu Feb 25 12:38:02 UTC 2021
Mathieu Arnold <mat at freebsd.org> writes:
> On Thu, Feb 25, 2021 at 11:30:22AM +0000, Jan Beich wrote:
>
>> +post-patch: terminfo-patch
>> +terminfo-patch:
>> + @${REINPLACE_CMD} '/datadir/s/terminfo/site-&/' ${WRKSRC}/meson.build
>
> This seems overengineered, there is no post-patch target in the
> Makefile, so, why create a new target, and hook it up to a non existing
> target, instead of just using a regular post-patch target?
The whole conditional was self-contained, so if someone added a post-patch
for all FreeBSD releases (e.g., under portmgr blanket) they wouldn't have
to test on -CURRENT separately.
> If there is a good reason for that, it is not obvious, and the reason
> needs to be documented in the Makefile.
I've found another style bug (= vs. +=) and fixed in r566530.
More information about the svn-ports-head
mailing list