svn commit: r540489 - in head/devel/fhist: . files

[Mathieu Arnold]

On Fri, Jun 26, 2020 at 01:38:11PM +0000, Alexey Dokuchaev wrote:
> On Fri, Jun 26, 2020 at 03:28:41PM +0200, Mathieu Arnold wrote:
> > On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote:
> > > ...
> > > Please, "svn revert" patches which forwent no functional changes prior
> > > to making commit.  It just clutters the diff and decreases SNR. :-(
> > 
> > In that particular case, it was correct to commit the patch, it has
> > functional change, the range information changed
> 
> I see only patch header change, and I'm pretty sure the old patch would
> apply just fine (if by "range information" you mean the line address).
> 
> Generally, patch(1) does fuzzy application very well, which allows to
> carry patches unmodified literally forever (until patched file changes
> enough so the patch no longer applies).
> 
> If you were talking about something else, please be more specific.

I was talking about the range information, yes, the line numbers.  It is
true that patch(1) does fuzzy patching, and it did when it applied that
patch.  The committer then checked that it was still building correctly,
and ran makepatch to regenerate the patch.

Now, the patches in the ports tree need to have a correct and coherent
behavior, and fuzzy patching gets it wrong from time to time.  This is
why range information is not noise, but important metadata that we
prefer to be correct all the time.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200626/5a9cdfbd/attachment.sig>