svn commit: r539792 - in head: . irc irc/smuxi irc/smuxi/files

[Alexey Dokuchaev]

On Mon, Jun 22, 2020 at 02:29:01AM +0000, Santhosh Raju wrote:
> New Revision: 539792
> URL: https://svnweb.freebsd.org/changeset/ports/539792
> 
> Log:
>   irc/smuxi: Revive the port

Hi Santhosh,

Thanks for reviving th port!  I have a few comments if you don't mind...

> Modified: head/irc/smuxi/Makefile
> ==============================================================================
> --- head/irc/smuxi/Makefile	Fri Jul 26 23:20:17 2013	(r323759)
> +++ head/irc/smuxi/Makefile	Mon Jun 22 02:29:01 2020	(r539792)
> @@ -1,41 +1,48 @@
> -# Created by: Romain Tartiere <romain at blogreen.org>

We typically retain original author attribution when reviving ports,
especially when most of their prior work remains.

> +DBUS_DESC=	Build with DBUS support
> +GTKSPELL_DESC=	Support spell checking
> +NLS_DESC=	Build with NLS support
> +NOTIFY_DESC=	Build with Notification Support

There are several problems with this block:
  - option description should not start with "Build" or "Enable",
    please take a look at examples in the Mk/bsd.options.desc.mk
  - DBUS_DESC, NLS_DESC, and NOTIFY_DESC are part of the standard
    options pool with pretty much same values and should be dropped
  - description for GTKSPELL is a bit too generic (again, you can
    grep SPELL /usr/ports/Mk/bsd.options.desc.mk for inspiration)

> +MAKE_JOBS_UNSAFE=	yes

Please try to include a short excerpt from the build log when marking ports
as unsafe, either as MAKE_JOBS_UNSAFE value or as part of the commit log.

When someone decides to revisit this, old build logs are usually long gone,
and this vagueness makes it quite hard to reason about the problem.

./danfe