svn commit: r526232 - head/x11-wm/hikari

[Piotr Kubaj]

That's what I thought at first, thanks for confirmation.

Otherwise, when I commit a change to one of my ports, I should add:
Approved by:	me (maintainer)

which I didn't notice anyone to use :)

On 20-02-16 19:00:10, Mathieu Arnold wrote:
> On Sun, Feb 16, 2020 at 08:16:39AM -0800, Yuri wrote:
> > On 2020-02-16 02:48, Piotr Kubaj wrote:
> > > Is it necessary even for trivial build fixes?
> > 
> > 
> > If this is an unbreak - then you can commit it and 'Approved by' should be
> > 'portmgr'.
> > 
> > If this is some formatting or trivial fix (license/NO_ARCH/helpers/WWW) -
> > then you can commit it and 'Approved by' should be 'portmgr blanket'.
> > 
> > Otherwise you should ask the maintainer.
> > 
> > But the 'Approved by' line, I think, should always be present when
> > MAINTAINER is not you and not ports@
> 
> You only use Approved by: someone if someone actually approved the
> change you are committing.  Changes that are covered by the blanket
> approval do not require any approval, they are not approved by anyone,
> they are just authorized to anyone.
> 
> -- 
> Mathieu Arnold



-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200216/5b1d303a/attachment.sig>