svn commit: r525015 - in head/graphics: . xviewer

[Alexey Dokuchaev]

On Mon, Feb 03, 2020 at 02:38:23PM -0500, Steve Wills wrote:
> On 2/3/20 1:39 AM, Alexey Dokuchaev wrote:
> > New Revision: 525015
> > URL: https://svnweb.freebsd.org/changeset/ports/525015
> > 
> > [...]
> > +post-patch:
> > +	@${REINPLACE_CMD} -e '/CINNAMON_DESKTOP_REQUIRED/s,3\.2\.0,2.4.2,' \
> > +		${WRKSRC}/configure.ac
> > +
> 
> This would be better as a patch.

Not really.  Then `x11/cinnamon-desktop' port would get updated, this
"patch" could be removed with much less repochurn than the real patch
file.  Until they become too heavy, I find sed(1) expressions easier
and more robust.  I usually provide enough context so they'd either
DTRT or nothing.

> [...]
> -GLIB_SCHEMAS=	org.x.viewer.enums.xml org.x.viewer.gschema.xml
> +GLIB_SCHEMAS=	org.x.viewer.enums.xml \
> +		org.x.viewer.gschema.xml

These two words are short enough to not overflow the 80-char line when
placed together, I don't see the need to force the wrap.

./danfe