svn commit: r530275 - in head/sysutils/checkrestart: . files

[Baptiste Daroussin]

On Fri, Apr 03, 2020 at 09:40:37AM +0200, Mathieu Arnold wrote:
> On Thu, Apr 02, 2020 at 07:56:16PM +0200, Fernando Apesteguía wrote:
> > On Thu, Apr 2, 2020 at 2:00 PM Mateusz Piotrowski <0mp at freebsd.org> wrote:
> > >
> > > Hi,
> > >
> > > On 4/2/20 1:51 PM, Fernando Apesteguía wrote:
> > > > Author: fernape
> > > > Date: Thu Apr  2 11:51:24 2020
> > > > New Revision: 530275
> > > > URL: https://svnweb.freebsd.org/changeset/ports/530275
> > > >
> > > > Log:
> > > >    sysutils/checkrestart: Update to 0.5.0
> > > ...
> > > > Added: head/sysutils/checkrestart/files/checkrestart.in
> > > > ==============================================================================
> > > > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > > > +++ head/sysutils/checkrestart/files/checkrestart.in  Thu Apr  2 11:51:24 2020        (r530275)
> > > > @@ -0,0 +1,70 @@
> > > > +#!/bin/sh
> > > > +# $FreeBSD$
> > > > +
> > > > +if [ -r /etc/defaults/periodic.conf ]; then
> > > > +    . /etc/defaults/periodic.conf
> > > > +    source_periodic_confs
> > > > +fi
> > > > +
> > > > +: "${daily_checkrestart_enable:=NO}"
> > > > +: "${daily_checkrestart_weekdays:=1234567}" # Days of the week to run, Monday=1
> > > > +: "${daily_checkrestart_users:=}"           # User names or IDs to check
> > > > +: "${daily_checkrestart_jails:=}"           # Jail names or IDs to check
> > > > +: "${daily_checkrestart_procs:=}"           # Process names or IDs to check
> > > > +
> > > > +checkrestartcmd=/usr/local/bin/checkrestart
> > >
> > > This should probably utilize %%PREFIX%%.
> > >
> > > > +
> > > > +case "${daily_checkrestart_enable}" in
> > > > +    [Yy][Ee][Ss])
> > > Please use checkyesno from rc.subr(8) instead.
> > 
> > Hi Mateusz,
> > 
> > Thanks for the point. Would you have a look at
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245283? The
> > maintainer doesn't see appropriate this last suggestion. Feel free to
> > jump in.
> 
> You know, thre reason we have committers and not a script that applies
> the patch and commits is so that we can change the submission to better
> fit our policies.  You do not need the maintainer's approval to change
> that.  See the penultimate paragraph here:
> 
> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html
> 

Actually the propose change is wrong as the submitter states no periodic scripts
are using it, for a very good reason, /etc/defauls/periodic.conf already provide
a function for that which handles specific case for periodic:
check_yesno_period

So yes there should be a change to the port, but the change is to use that
function and not include rc.subr.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200403/054c8114/attachment.sig>