svn commit: r511300 - head/devel/llvm80

[Brooks Davis]

On Thu, Sep 12, 2019 at 04:31:53PM +0200, Tobias Kortkamp wrote:
> On Thu, Sep 12, 2019 at 02:18:01PM +0000, Brooks Davis wrote:
> > On Thu, Sep 12, 2019 at 03:27:06PM +0200, Tobias Kortkamp wrote:
> > > On Fri, Sep 06, 2019 at 11:04:44AM +0000, Brooks Davis wrote:
> > > > Author: brooks
> > > > Date: Fri Sep  6 11:04:44 2019
> > > > New Revision: 511300
> > > > URL: https://svnweb.freebsd.org/changeset/ports/511300
> > > > 
> > > > Log:
> > > >   Assorted build improvements:
> > > >   
> > > >    - Add a build conflict for commonmark-cmark-* when DOCS are enabled.
> > > >      This prevents a failure later on in the build. [0]
> > > >   
> > > >    - Add a new option BE_AMDGPU which can be used to enable the AMDGPU
> > > >      backed used by mesa when BE_NATIVE or BE_FREEBSD is set.  Enable this
> > > >      option by default to limit later surprises. [1]
> > > >   
> > > >    - New option PYCLANG to add python binding for clang. [2]
> > > >   
> > > >   PR:		239636 [0], 230789 [1], 239990 [2]
> > > >   Submitted by:	chardon.frederic at gmail.com [2]
> > > >   Sponsored by:	DARPA, AFRL
> > > > 
> > > > Modified:
> > > >   head/devel/llvm80/Makefile
> > > >   head/devel/llvm80/pkg-plist
> > > > 
> > > > [...]
> > > > +.if ${PORT_OPTIONS:MPYCLANG}
> > > > +PYCLANG_PATTERN=	(clang\/(__init__|cindex|enumerations).py$)
> > > > +.endif
> > > 
> > > Is the $ in PYCLANG_PATTERN significant?  make ignores it and the
> > > pattern might be wrong when used in build-plist.
> > > 
> > > $ make -C devel/llvm80 -V PYCLANG_PATTERN
> > > (clang\/(__init__|cindex|enumerations).py)
> > 
> > It does its job today and generates the right plist...  Do you have a
> > specific problem to report?  The patterns are necessarily a bit adhoc.
> 
> Nothing more than what I already said.  It has broken a couple of
> my ports tools.  If it is clear that the $ does not do anything in
> PYCLANG_PATTERN then everything is ok here.

Ah, sorry, I misread your first message.  It does look like it is harmlessly
being removed and doesn't matter at this point.  It should be "$$" and
should be moved to the end.  I'll do that at some point.

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190912/dbbe5557/attachment.sig>