svn commit: r518693 - head/games/aquaria

[Tobias Kortkamp]

On Sat, Nov 30, 2019 at 08:18:43AM +0100, Jan Beich wrote:
> Tobias Kortkamp <tobik at freebsd.org> writes:
> 
> > On Sat, Nov 30, 2019 at 02:13:19AM +0000, Jan Beich wrote:
> >
> >> Author: jbeich
> >> Date: Sat Nov 30 02:13:18 2019
> >> New Revision: 518693
> >> URL: https://svnweb.freebsd.org/changeset/ports/518693
> >> 
> >> Log:
> >>   games/aquaria: partially revert r518662
> >>   
> >>   aarch64 and armv7 weren't affected. amd64 was fixed since LLD 7 but
> >>   i386 still fails. Losing LTO (and CFI) support is not worth just for
> >>   consistency with an architecture that may become Tier2 in future.
> >>   
> >>   ld: error: cannot preempt symbol: alGetSourcei
> >>   >>> defined in /usr/local/lib/libopenal.so
> >>   >>> referenced by FmodOpenALBridge.cpp
> >>   >>>               CMakeFiles/aquaria.dir/BBGE/FmodOpenALBridge.cpp.o:(OggDecoder::decode_loop(OggDecoder*))
> >>   
> >>   Pointy hat to:	jbeich (bug 242307 comment 11)
> >
> > What do you think about setting 
> >
> > LDFLAGS_i386=	-Wl,-z,notext
> >
> > here instead (also in openal-soft)?  It unbreaks the build of either
> > one with lld on 12.1 i386.
> 
> Looks good. I've also tested runtime in 12.1 i386 jail.

Thanks for testing.  It also built fine on 13.0 i386.  I've applied
it to openal-soft in r518709.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20191130/677beea7/attachment.sig>