svn commit: r502461 - in head/www/chromium: . files

[Mathieu Arnold]

On Fri, May 24, 2019 at 12:58:13PM +0000, Alexey Dokuchaev wrote:
> On Fri, May 24, 2019 at 10:47:36PM +1000, Kubilay Kocak wrote:
> > On 24/05/2019 10:42 pm, Alexey Dokuchaev wrote:
> > > On Fri, May 24, 2019 at 12:34:58PM +0000, Rene Ladan wrote:
> > >> New Revision: 502461
> > >> URL: https://svnweb.freebsd.org/changeset/ports/502461
> > >>
> > >> Log:
> > >>    www/chromium: update to 74.0.3729.157
> > >>    
> > >>    Submitted by:	Matthias Wolf via GitHub (#150 #151)
> > >>    MFH:		2019Q2
> > > 
> > > Many patches that were modified only changed in metainfo or context
> > > (+/- few lines) and thus just cluttered this very noisy commit for
> > > no real benefit.
> > > 
> > > Please try to exclude them from the commit batch next time to reduce
> > > amount of repochurn.
> > 
> > fwiw, makepatch is now ignoring metadata only changes. Not sure when
> > this new feature crept in.
> 
> Technically, line changes are not strictly metadata only changes, and
> the old patch might not apply.  However, most of the times new address
> is within a few lines, and patch(1) can easily find the right context
> even when address is off by several hundred lines.
> 
> It might not be very important for small commit batch, but for large
> commits, minizing the diff becomes essential since it greatly helps
> to understand, rollback, or/and replay changes (especially if there
> is some local work in place, e.g. some custom patches).

makepatch does not ignore line number changes.  When diff generates a patch
like this:

----------------------------------------------------------------------
--- perl.c.orig 2019-05-19 06:31:53.000000000 +0000
+++ perl.c      2019-05-20 10:42:27.140534000 +0000
@@ -2009,23 +2009,7 @@ S_Internals_V(pTHX_ CV *cv)
     PUSHs(Perl_newSVpvn_flags(aTHX_ non_bincompat_options,
                              sizeof(non_bincompat_options) - 1, SVs_TEMP));

-#ifndef PERL_BUILD_DATE
-#  ifdef __DATE__
----------------------------------------------------------------------

It will first clean it up, and store this:

----------------------------------------------------------------------
--- perl.c.orig 2019-05-19 06:31:53 UTC
+++ perl.c
@@ -2009,23 +2009,7 @@ S_Internals_V(pTHX_ CV *cv)
     PUSHs(Perl_newSVpvn_flags(aTHX_ non_bincompat_options,
                              sizeof(non_bincompat_options) - 1, SVs_TEMP));

-#ifndef PERL_BUILD_DATE
-#  ifdef __DATE__
----------------------------------------------------------------------

It will then create a more cleaned up version for comparing, only keeping data
and metadata (with both the new and the current patch), which will look like
this:

----------------------------------------------------------------------
+++ perl.c
@@ -2009,23 +2009,7 @@
     PUSHs(Perl_newSVpvn_flags(aTHX_ non_bincompat_options,
                              sizeof(non_bincompat_options) - 1, SVs_TEMP));

-#ifndef PERL_BUILD_DATE
-#  ifdef __DATE__
----------------------------------------------------------------------

And if something thanges in this, then the new patch is used.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190527/5530378d/attachment.sig>