svn commit: r494657 - head/x11/rofi-pass
Kyle Evans
kevans at freebsd.org
Mon Mar 4 22:20:55 UTC 2019
On Mon, Mar 4, 2019 at 4:09 PM Steve Wills <swills at freebsd.org> wrote:
>
> Author: swills
> Date: Mon Mar 4 22:08:50 2019
> New Revision: 494657
> URL: https://svnweb.freebsd.org/changeset/ports/494657
>
> Log:
> x11/rofi-pass: remove unnecessary dependencies
>
> PR: 236225
> Submitted by: alex at xanderio.de (maintainer)
>
Hi,
I did a pass over this to make sure it wasn't using grep features that
we don't quite support but don't treat as errors -- that turned out
alright, but it turns out the sed usage is slightly wrong in one place
[1] for our world.
I would recommend sending a patch upstream to change this to the more
portable expression `sed -Ee 's/[[:blank:]]+$//'`, though it's
probably not critical to patch it locally since it just strips
whitespace off the end (or doesn't, as the case is now =)).
Thanks,
Kyle Evans
[1] https://github.com/carnager/rofi-pass/blob/master/addpass#L56
More information about the svn-ports-head
mailing list