svn commit: r503828 - head/graphics/photoflow

[Tobias Kortkamp]

On Mon, Jun 10, 2019 at 01:42:19PM +0200, Tobias Kortkamp wrote:
> On Sun, Jun 09, 2019 at 03:44:36PM +0000, Yuri Victorovich wrote:
> > Author: yuri
> > Date: Sun Jun  9 15:44:36 2019
> > New Revision: 503828
> > URL: https://svnweb.freebsd.org/changeset/ports/503828
> > 
> > Log:
> >   graphics/photoflo: Rename the option
> >   
> >   Reported by:	mat
> > 
> > Modified:
> >   head/graphics/photoflow/Makefile
> > 
> > Modified: head/graphics/photoflow/Makefile
> > ==============================================================================
> > --- head/graphics/photoflow/Makefile	Sun Jun  9 15:40:52 2019	(r503827)
> > +++ head/graphics/photoflow/Makefile	Sun Jun  9 15:44:36 2019	(r503828)
> > @@ -32,11 +32,11 @@ LDFLAGS+=	-lexecinfo
> >  
> >  INSTALLS_ICONS=	yes
> >  
> > -OPTIONS_DEFINE=			OCIO_ENABLED
> > -OPTIONS_SUB=			yes
> > +OPTIONS_DEFINE=		OCIO
> > +OPTIONS_SUB=		yes
> >  
> > -OCIO_ENABLED_DESC=		Enable the integration of OpenColorIO
> > -OCIO_ENABLED_CMAKE_BOOL=	OCIO_ENABLED
> > -OCIO_ENABLED_LIB_DEPENDS=	libOpenColorIO.so:graphics/opencolorio
> > +OCIO_DESC=		Enable the integration of OpenColorIO
> > +OCIO_CMAKE_BOOL=	OCIO_ENABLED
> > +OCIO_LIB_DEPENDS=	libOpenColorIO.so:graphics/opencolorio
> 
> OCIO_ENABLED needs to be replaced with OCIO in pkg-plist too [1].
> 
> Another problem is that the build fails during configure with OCIO=on:
> 
> -- ADDITIONAL_LIBS: fftw3_threadspthreaddl/usr/local/lib/libOpenColorIO.so
> CMake Error at /usr/local/share/cmake/Modules/ExternalProject.cmake:2427 (message):
>   error: could not find git for clone of aces-ocio
> Call Stack (most recent call first):
>   /usr/local/share/cmake/Modules/ExternalProject.cmake:3211 (_ep_add_download_command)
>   data/CMakeLists.txt:24 (ExternalProject_Add)
> 
> 
> -- Configuring incomplete, errors occurred!
> See also "/wrkdirs/usr/ports/graphics/photoflow/work/.build/CMakeFiles/CMakeOutput.log".
> See also "/wrkdirs/usr/ports/graphics/photoflow/work/.build/CMakeFiles/CMakeError.log".
> *** Error code 1
> 
> [1] http://package18.nyi.freebsd.org/data/120amd64-default-PR238330/2019-06-09_20h26m27s/logs/errors/photoflow-0.2.8.1260.log

We have another instance of 'xLICENSE_FILE' here again too.  The
license also seems to be GPLv3+ not APACHE20.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190610/e2ee1564/attachment.sig>