svn commit: r493407 - head/graphics/xpdf4

[Tobias Kortkamp]

On Tue, Feb 19, 2019 at 10:55:38PM -0800, Cy Schubert wrote:
> In message <20190220063422.GA18880 at urd.tobik.me>, Tobias Kortkamp 
> writes:
> > 
> >
> > --OXfL5xGRrasGEqWY
> > Content-Type: text/plain; charset=us-ascii
> > Content-Disposition: inline
> > Content-Transfer-Encoding: quoted-printable
> >
> > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote:
> > > Author: cy
> > > Date: Wed Feb 20 06:14:57 2019
> > > New Revision: 493407
> > > URL: https://svnweb.freebsd.org/changeset/ports/493407
> > >=20
> > > Log:
> > >   Remove whitespace in USE_QT, otherwise qmake_build is ignored.
> > >  =20
> > >   Reported by:	Paul Beard <paulbeard at gmail.com>
> > >=20
> > > Modified:
> > >   head/graphics/xpdf4/Makefile
> > >=20
> > > Modified: head/graphics/xpdf4/Makefile
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D
> > > --- head/graphics/xpdf4/Makefile	Wed Feb 20 04:50:53 2019	(r49340
> > 6)
> > > +++ head/graphics/xpdf4/Makefile	Wed Feb 20 06:14:57 2019	(r49340
> > 7)
> > > @@ -27,8 +27,7 @@ SUB_FILES=3D	xpdf-man.conf
> > > =20
> > >  USES=3D		compiler:c++11-lang cmake localbase:ldflags \
> > >  		desktop-file-utils qt:5
> > > -USE_QT=3D		buildtools_build,concurrent,core,gui,network,printsuppo
> > rt,\
> > > -		qmake_build,svg,widgets
> > > +USE_QT=3D		buildtools_build,concurrent,core,gui,network,printsuppo
> > rt,qma=
> > ke_build,svg,widgets
> >
> > Next step: Replace the , with spaces to actually add Qt dependencies
> > to the port.  Check with build-depends-list, run-depends-list,
> > stage-qa.  Currently the port has no Qt 5 dependencies and it fails
> > to build in Poudriere:
> >
> > =3D=3D=3D> Checking for items in pkg-plist which are not in STAGEDIR
> > Error: Missing: libexec/xpdf/xpdf
> > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz
> > =3D=3D=3D> Error: Plist issues found.
> 
> This must have been wrong all along. I'm not sure how it would have 
> ever built before.

Thanks for fixing it.  I can confirm that it builds fine now for
me in Poudriere.

But let me clarify.  It was not broken before, only after today.
Previously the port used an options helper like

GUI_USE=	QT=x,y,z

which was correct.  This translates (see [1]) to

.if ${PORT_OPTIONS:MGUI}
USE_QT+=	x y z
.endif

as it should be.  It however does *not* translate to

.if ${PORT_OPTIONS:MGUI}
USE_QT+=	x,y,z
.endif

So the refactoring from earlier (removing the GUI option) was not
correct and the problem was only introduced today.

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html#options-use
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190220/0c9a144a/attachment.sig>