svn commit: r492359 - head/graphics/ufraw

[Tobias Kortkamp]

On Thu, Feb 7, 2019, at 12:02, Rodrigo Osorio wrote:
> Author: rodrigo
> Date: Thu Feb  7 11:02:46 2019
> New Revision: 492359
> URL: https://svnweb.freebsd.org/changeset/ports/492359
> 
> Log:
>   Be able to build ufraw without GTK2 option
>   
>   Add gnome to the uses to make testport happy
>   Bump portrevision
>   
>   PR:		234436
>   Reported by:	Thomas Guymer <t.m.guymer at thomasguymer.co.uk>
> 
> Modified:
>   head/graphics/ufraw/Makefile
>   head/graphics/ufraw/pkg-plist
> 
> Modified: head/graphics/ufraw/Makefile
> ==============================================================================
> --- head/graphics/ufraw/Makefile	Thu Feb  7 10:55:09 2019	(r492358)
> +++ head/graphics/ufraw/Makefile	Thu Feb  7 11:02:46 2019	(r492359)
> @@ -3,7 +3,7 @@
>  
>  PORTNAME=	ufraw
>  PORTVERSION=	0.22
> -PORTREVISION=	8
> +PORTREVISION=	9
>  CATEGORIES=	graphics
>  
>  MAINTAINER=	rodrigo at FreeBSD.org
> @@ -20,7 +20,7 @@ LIB_DEPENDS=	libtiff.so:graphics/tiff \
>  
>  GNU_CONFIGURE=	yes
>  CONFIGURE_ARGS=	--enable-extras
> -USES=		compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf
> +USES=		compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf gnome
>  
>  CPPFLAGS+=	-I${LOCALBASE}/include
>  LDFLAGS+=	-lpthread -L${LOCALBASE}/lib
> @@ -58,6 +58,13 @@ GTK2_CONFIGURE_WITH=	gtk
>  GNOME_USE=		GNOME=gconf2
>  GNOME_CONFIGURE_ENABLE=	mime
>  GNOME_VARS=		CATEGORIES+=gnome GCONF_SCHEMAS=${PORTNAME}.schemas
> +
> +.include <bsd.port.options.mk>
> +.if ${PORT_OPTIONS:MGTK2}
> +PLIST_SUB+=	NOGTK2=""
> +.else
> +PLIST_SUB+=	NOGTK2="@comment "
> +.endif

Naming it NOGTK2 is very confusing.  OPTIONS_SUB=yes already adds
something like this just named after the option directly.  Why not
just use %%GTK2%% in pkg-plist to achieve the same thing?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190207/1c27a81d/attachment.sig>