svn commit: r520989 - in head: comms/xastir graphics/GraphicsMagick graphics/aaphoto graphics/dcraw graphics/dcraw-m graphics/devil graphics/devil/files graphics/digikam graphics/exact-image graphi...

[Tobias Kortkamp]

On Fri, Dec 27, 2019 at 10:26:55PM +0100, Baptiste Daroussin wrote:
> On Sat, Dec 28, 2019 at 12:25:01AM +0300, Dmitry Marakasov wrote:
> > * Baptiste Daroussin (bapt at FreeBSD.org) wrote:
> > 
> > > Author: bapt
> > > Date: Fri Dec 27 13:43:00 2019
> > > New Revision: 520989
> > > URL: https://svnweb.freebsd.org/changeset/ports/520989
> > > 
> > > Log:
> > >   Update jasper to 2.0.16
> > >   
> > >   This is needed to be able to update gegl to latest version.
> > >   Bump revision of all consumer as the ABI is not 100% backward compatible.
> > >   Provide a patch for graphics/devil to properly build with latest jasper.
> > >   While here add a missing USES=xorg to graphics/devil
> > > 
> > > Modified: head/graphics/devil/Makefile
> > > ==============================================================================
> > > --- head/graphics/devil/Makefile	Fri Dec 27 13:31:41 2019	(r520988)
> > > +++ head/graphics/devil/Makefile	Fri Dec 27 13:43:00 2019	(r520989)
> > > @@ -3,7 +3,7 @@
> > >  
> > >  PORTNAME=	devil
> > >  PORTVERSION=	1.7.8
> > > -PORTREVISION=	23
> > > +PORTREVISION=	24
> > >  PORTEPOCH=	1
> > >  CATEGORIES=	graphics
> > >  MASTER_SITES=	SF/openil/DevIL/${PORTVERSION}
> > > @@ -12,7 +12,7 @@ DISTNAME=	DevIL-${PORTVERSION}
> > >  MAINTAINER=	amdmi3 at FreeBSD.org
> > >  COMMENT=	Full featured cross-platform image library
> > >  
> > > -USES=		alias autoreconf gmake libtool localbase pkgconfig
> > > +USES=		alias autoreconf gmake libtool localbase pkgconfig xorg
> > 
> > Was this indended? It breaks the port.
> > 
> 
> Weird, it passes my poudriere run, but feel free to revert that part

$ make -C graphics/devil WITHOUT=X11
===>  devil-1.7.8_24,1 need to specify xorg modules with USE_XORG.
*** Error code 1

The addition of USES=xorg is wrong here in the first place.  The
only reason the framework even asks you to add USES=xorg is because
of an unfixed bug in USES=gl [1,2] where it creates empty USE_XORG
which trigger the warning in bsd.port.mk because USE_XORG happens
to be defined afterwards.  Note how there is no direct USE_XORG in
graphics/devil itself.

Maybe someone from portmgr can take a look and acknowledge [1,2]
because I think this bug is confusing and has been in the tree for
long enough.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241790
[2] https://lists.freebsd.org/pipermail/svn-ports-head/2019-November/224968.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20191227/7ea9f599/attachment.sig>