svn commit: r500497 - head/security/klee

[Gleb Popov]

On Tue, Apr 30, 2019 at 11:15 PM Piotr Kubaj <pkubaj at anongoth.pl> wrote:

> Is there a point in creating a PR that you accept and then adding you to
> reviewers?
>
> Or do you mean only doing a review?
>

Yes, the point is that you can do without a PR at all, since I can approve
the change on the Phabricator.


> On 19-04-30 18:39:02, Gleb Popov wrote:
> >On Tue, Apr 30, 2019 at 6:29 PM Piotr Kubaj <pkubaj at freebsd.org> wrote:
> >
> >> Author: pkubaj
> >> Date: Tue Apr 30 14:29:20 2019
> >> New Revision: 500497
> >> URL: https://svnweb.freebsd.org/changeset/ports/500497
> >>
> >> Log:
> >>   security/klee: fix build with GCC-based architectures
> >>
> >>   Add USES=compiler:c++14-lang to fix build on GCC architectures:
> >>   Make Error in lib/Basic/CMakeLists.txt:
> >>     Target "kleeBasic" requires the language dialect "CXX14" (with
> compiler
> >>     extensions), but CMake does not know the compile flags to use to
> >> enable it.
> >>
> >>   PR:           237623
> >>   Approved by:  arrowd (maintainer), mat (mentor)
> >>   Differential Revision:        https://reviews.freebsd.org/D20088
> >>
> >> Modified:
> >>   head/security/klee/Makefile
> >>
> >> Modified: head/security/klee/Makefile
> >>
> >>
> ==============================================================================
> >> --- head/security/klee/Makefile Tue Apr 30 14:26:31 2019
> (r500496)
> >> +++ head/security/klee/Makefile Tue Apr 30 14:29:20 2019
> (r500497)
> >> @@ -17,7 +17,8 @@ BUILD_DEPENDS=
> >> llvm-config${LLVM_DEFAULT}:devel/llvm${
> >>  RUN_DEPENDS=   llvm-config${LLVM_DEFAULT}:devel/llvm${LLVM_DEFAULT} \
> >>                 ${PYTHON_PKGNAMEPREFIX}tabulate>0:devel/py-tabulate@
> >> ${PY_FLAVOR}
> >>
> >> -USES=          cmake localbase pkgconfig python:3.5+,run shebangfix
> >> +USES=          cmake compiler:c++14-lang localbase pkgconfig
> >> python:3.5+,run \
> >> +               shebangfix
> >>  USE_GITHUB=    yes
> >>  SHEBANG_FILES= tools/klee-stats/klee-stats tools/ktest-tool/ktest-tool
> >>  USE_LDCONFIG=  yes
> >>
> >>
> >I have an account on our Phab, so you can add @arrowd to reviewers there.
> >
> >--
> >This message has been scanned for viruses and
> >dangerous content by MailScanner, and is
> >believed to be clean.
> >
>