svn commit: r482889 - head/editors/ne

[Tobias Kortkamp]

On Wed, Oct 24, 2018, at 10:00, Wen Heping wrote:
> Author: wen
> Date: Wed Oct 24 08:00:34 2018
> New Revision: 482889
> URL: https://svnweb.freebsd.org/changeset/ports/482889
> 
> Log:
>   - Update to 3.1.2
>   
>   PR:		232338
>   Submitted by:	ndowens at yahoo.com
> 
> Modified:
>   head/editors/ne/Makefile
>   head/editors/ne/distinfo
> 
> Modified: head/editors/ne/Makefile
> ==============================================================================
> --- head/editors/ne/Makefile	Wed Oct 24 07:17:16 2018	(r482888)
> +++ head/editors/ne/Makefile	Wed Oct 24 08:00:34 2018	(r482889)
> @@ -2,7 +2,7 @@
>  # $FreeBSD$
>  
>  PORTNAME=	ne
> -PORTVERSION=	3.1.1
> +PORTVERSION=	3.1.2
>  CATEGORIES=	editors
>  MASTER_SITES=	http://ne.di.unimi.it/
>  
> @@ -12,11 +12,10 @@ COMMENT=	Nice and powerful editor
>  LICENSE=	GPLv3
>  LICENSE_FILE=	${WRKSRC}/COPYING
>  
> -BUILD_WRKSRC=	${WRKSRC}/src
> -
>  USES=		gmake makeinfo perl5
>  USE_PERL5=	build
>  USE_CSTD=	c99
> +
>  MAKEFILE=	makefile
>  MAKE_ARGS=	CC="${CC}" \
>  		OPTS="${CFLAGS}" \
> @@ -24,12 +23,12 @@ MAKE_ARGS=	CC="${CC}" \
>  		NE_GLOBAL_DIR="${DATADIR}"
>  ALL_TARGET=	ne
>  
> -LDFLAGS+=	-lgnuregex
> +LDFLAGS=	-lgnuregex

I think that this should be kept as LDFLAGS+=, so that user settings
in make.conf are not completely ignored by the port.

>  
> +BUILD_WRKSRC=	${WRKSRC}/src
>  INFO=		ne
> -PORTDOCS=	*
> -PORTDATA=	*
> -PLIST_FILES=	bin/ne man/man1/ne.1.gz
> +DOCS=		CHANGES NEWS README.md doc/default.* \
> +		doc/ne.pdf doc/ne.txt doc/html/*
>  
>  OPTIONS_DEFINE=		DEBUG DOCS
>  
> @@ -40,33 +39,15 @@ post-patch:
>  		's|"regex\.h"|<gnu/regex.h>|g'
>  	@${REINPLACE_CMD} -e \
>  		's|-O3|| ; \
> -		 /[[:space:]]regex.o/d ; \
> +		/[[:space:]]regex.o/d ; \
>  		 s|regex.h$$||g' ${BUILD_WRKSRC}/makefile
> +	@${REINPLACE_CMD} -e '/cp -pR/d' ${WRKSRC}/makefile
>  
> -post-build:
> -	cd ${WRKSRC}/doc && makeinfo ne.texinfo
> +post-install:
> +	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/ne
>  
> -do-install:
> -	(cd ${BUILD_WRKSRC} && ${INSTALL_PROGRAM} ne \
> -		${STAGEDIR}${PREFIX}/bin)
> -	(cd ${WRKSRC}/doc && ${INSTALL_MAN} ne.1 \
> -		${STAGEDIR}${MANPREFIX}/man/man1)
> -	(cd ${WRKSRC}/doc && ${INSTALL_DATA} ne.info \
> -		${STAGEDIR}${PREFIX}/${INFO_PATH})
> -	@${MKDIR} ${STAGEDIR}${DATADIR}/macros
> -	(cd ${WRKSRC}/macros && ${INSTALL_DATA} * \
> -		${STAGEDIR}${DATADIR}/macros)
> -	@${MKDIR} ${STAGEDIR}${DATADIR}/syntax
> -	(cd ${WRKSRC}/syntax && ${INSTALL_DATA} *.jsf \
> -		${STAGEDIR}${DATADIR}/syntax)
> -
>  do-install-DOCS-on:
>  	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> -	(cd ${WRKSRC} && ${INSTALL_DATA} CHANGES NEWS README.md \
> -		${STAGEDIR}${DOCSDIR})
> -	(cd ${WRKSRC}/doc && ${INSTALL_DATA} default.* ne.pdf ne.txt \
> -		${STAGEDIR}${DOCSDIR})
> -	@(cd ${WRKSRC}/doc && ${COPYTREE_SHARE} html \
> -		${STAGEDIR}${DOCSDIR})
> +	${INSTALL_DATA} ${DOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
>  
>  .include <bsd.port.mk>

Did you forget to svn add a pkg-plist?  PORTDOCS, PORTDATA, and
PLIST_FILES are all gone now, so there probably should be one if
this port is supposed to do something.  Right now the build succeeds
(if not in port testing mode) but the package is empty.