svn commit: r470615 - head

[Mathieu Arnold]

On Thu, May 24, 2018 at 04:13:30PM +0000, Tijl Coosemans wrote:
> On Thu, 24 May 2018 16:37:52 +0200 Mathieu Arnold <mat at FreeBSD.org> wrote:
> > On Thu, May 24, 2018 at 02:54:50PM +0200, Tijl Coosemans wrote:
> >> On Thu, 24 May 2018 14:45:50 +0200 Mathieu Arnold <mat at FreeBSD.org> wrote:
> >>> On Tue, May 22, 2018 at 04:02:46PM +0200, Tijl Coosemans wrote:
> >>>> On Tue, 22 May 2018 13:58:34 +0000 (UTC) Mathieu Arnold <mat at FreeBSD.org> wrote:
> >>>>> --- head/CHANGES	Tue May 22 13:58:03 2018	(r470614)
> >>>>> +++ head/CHANGES	Tue May 22 13:58:33 2018	(r470615)
> >>>>> @@ -152,8 +152,7 @@ AUTHOR: mat at FreeBSD.org
> >>>>>  
> >>>>>    In all the ports with Python dependencies, the *_DEPENDS entries MUST end
> >>>>>    with the flavor so that the framework knows which to build/use.  This is done
> >>>>> -  by appending '@${PY_FLAVOR}' after the origin (or @${FLAVOR} if in a Python
> >>>>> -  module with Python flavors, as the content will be the same).  For example:
> >>>>> +  by appending '@${PY_FLAVOR}' after the origin.  For example:
> >>>>>  
> >>>>>      RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}
> >>>> 
> >>>> There are still some dependencies under Mk/ without @${PY_FLAVOR}.
> >>>
> >>> I cannot find any, can you be less vague? (or better, just fix them.)
> >>> 
> >> 
> >> Some lines that look suspicious:
> > 
> > All of those only work with Python 2.7, they all depend on a file
> > though, so they are more or less flavor independant, and will work if
> > the default is not 2.7.
> 
> But a port like devel/py-gobject is still flavored even if it has only
> one flavor.  Are you saying that in that case depending on category/port
> without @flavor is fine?  I think I prefer to keep it simple and always
> require @flavor, like it says in the text above.

Mmmm, it's not that simple.  Requiring the flavor is fine for Python
modules, because it'll get imported and installing the wrong version
will not work.  But if a port wants to run some command that is in fact
a Python script, the flavor does not matter.
All in all, I am not sure what to do with those dependencies, the
problem is that PY_FLAVOR will only be there if USES=python is there,
and I don't have the cycles to go through all the dependencies and look
it up.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180524/1b1865bc/attachment.sig>