svn commit: r469896 - in head/emulators/frodo: . files

Jan Beich jbeich at FreeBSD.org
Mon May 14 15:19:00 UTC 2018


Dirk Meyer <dinoex at FreeBSD.org> writes:

> +USE_CXXSTD=	gnu++98
> +CXXFLAGS+=	-std=gnu++98

One of these is redundant, see

# from Mk/bsd.port.mk
.for lang in C CXX
.if defined(USE_${lang}STD)
${lang}FLAGS:=	${${lang}FLAGS:N-std=*} -std=${USE_${lang}STD}
.endif

> +GNU_CONFIGURE=	yes
> +CONFIGURE_ENV=	CXXFLAGS='${CXXFLAGS}'
> +MAKE_ENV=	LDFLAGS='${LDFLAGS}'

CXXFLAGS and LDFLAGS are passed via environ(7) by default, see

# from Mk/bsd.port.mk
do-configure:
[...]
	@${MKDIR} ${CONFIGURE_WRKSRC}
	@(cd ${CONFIGURE_WRKSRC} && \
	    ${SET_LATE_CONFIGURE_ARGS} \
		if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \
	    CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \
	    LDFLAGS="${LDFLAGS}" LIBS="${LIBS}" \
	    INSTALL="/usr/bin/install -c" \
	    INSTALL_DATA="${INSTALL_DATA}" \
	    INSTALL_LIB="${INSTALL_LIB}" \
	    INSTALL_PROGRAM="${INSTALL_PROGRAM}" \
	    INSTALL_SCRIPT="${INSTALL_SCRIPT}" \
	    ${CONFIGURE_ENV} ${CONFIGURE_CMD} ${CONFIGURE_ARGS}; then \
			 ${ECHO_MSG} "===>  Script \"${CONFIGURE_SCRIPT}\" failed unexpectedly."; \
			 (${ECHO_CMD} ${CONFIGURE_FAIL_MESSAGE}) | ${FMT_80} ; \
			 ${FALSE}; \
		fi)


More information about the svn-ports-head mailing list